Fix build for Python 3.14 #638
Open
+110
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In extreme cases, isinstance(..., ()) may still return False instead of raising a TypeError
This uses private API now. Proper fix pending discussion in python/cpython#131148
* Add deprecation in docstring * Stop using private API, refs python/cpython#131148 * Use AbstractEventLoop instead, after @Vizonex's suggestion
Vizonex
reviewed
Sep 15, 2025
There was a problem hiding this comment.
@graingert @fantix
I like the fact that my approach from winloop is being utilized here but would it be smart if the install() function threw an error if 3.16+ is used?
|
I'm not sure, but I feel like it's fine that |
Vizonex
approved these changes
Sep 18, 2025
There was a problem hiding this comment.
Looks good. I'll have to mirror some of this myself even though I don't agree with all of it but it works nevertheless. You'll have to let 1st1 review it since I'm not the deciding factor but wanted to provide input and feedback to the project since I run the windows version of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #637